feat: add retentionPolicy in storage migration plan#2683
Open
duyanyan wants to merge 1 commit intoRedHatQE:mainfrom
Open
feat: add retentionPolicy in storage migration plan#2683duyanyan wants to merge 1 commit intoRedHatQE:mainfrom
duyanyan wants to merge 1 commit intoRedHatQE:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughTwo resource migration plan classes (MultiNamespaceVirtualMachineStorageMigrationPlan and VirtualMachineStorageMigrationPlan) now accept an optional Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
redhat-qe-bot
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
ocp_resources/virtual_machine_storage_migration_plan.py (1)
20-49:⚠️ Potential issue | 🟠 MajorDirect edits were made in generated resource code; move this change to the generator.
These updates are inside the generated section. Please implement
retention_policysupport in the class-generator source/template and regenerate this resource file, rather than maintaining manual edits here.As per coding guidelines, code in
**/ocp_resources/**between generated markers must not be edited directly; update the class-generator instead.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ocp_resources/virtual_machine_storage_migration_plan.py` around lines 20 - 49, The retention_policy change was made directly in the generated resource; instead update the class-generator/template so this field is generated. Modify the generator to add a retention_policy: str | None parameter to the resource constructor (alongside virtual_machines), assign it to self.retention_policy, and ensure to_dict emits _spec["retentionPolicy"] when self.retention_policy is not None (same pattern used for virtual_machines and MissingRequiredArgumentError checks); then regenerate ocp_resources/virtual_machine_storage_migration_plan.py so the manual edits are removed.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@ocp_resources/virtual_machine_storage_migration_plan.py`:
- Around line 20-49: The retention_policy change was made directly in the
generated resource; instead update the class-generator/template so this field is
generated. Modify the generator to add a retention_policy: str | None parameter
to the resource constructor (alongside virtual_machines), assign it to
self.retention_policy, and ensure to_dict emits _spec["retentionPolicy"] when
self.retention_policy is not None (same pattern used for virtual_machines and
MissingRequiredArgumentError checks); then regenerate
ocp_resources/virtual_machine_storage_migration_plan.py so the manual edits are
removed.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 55d6ea3f-6353-4115-b313-f000bb1dcb77
📒 Files selected for processing (2)
ocp_resources/multi_namespace_virtual_machine_storage_migration_plan.pyocp_resources/virtual_machine_storage_migration_plan.py
rnetser
reviewed
Mar 29, 2026
Comment on lines
26
to
31
| Each namespace item can contain: | ||
| - name (str): Namespace name | ||
| - retentionPolicy (str, optional): Namespace-level retention policy (e.g., 'keepSource' or 'deleteSource') | ||
| - virtualMachines (list): VMs to migrate | ||
| retention_policy (str, optional): Spec-level retention policy for source volumes (e.g., 'keepSource' or 'deleteSource'). | ||
|
|
Collaborator
There was a problem hiding this comment.
did you generate the resource using class-generator?
Contributor
Author
There was a problem hiding this comment.
no, but I have updated the code with class-generator, please review again
| r""" | ||
| Args: | ||
| virtual_machines (list[Any]): The virtual machines to migrate. | ||
| retention_policy (str, optional): Spec-level retention policy for source volumes (e.g., 'keepSource' or 'deleteSource'). |
duyanyan
force-pushed
the
retetion_policy
branch
from
061a4b6 to
664affc
Compare
redhat-qe-bot2
added
size/S
and removed
commented-rnetser
commented-coderabbitai[bot]
commented-duyanyan
size/XS
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description:
Add retentionPolicy in storage migration plan resources
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:
Summary by CodeRabbit